Use UTF-8 for test case JSON files#860
Open
Ghraven wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A few Burr test-case JSON helpers still rely on the platform default text encoding when reading or writing JSON/JSONL files. That can make generated test fixtures or lifecycle logs less portable on systems where the default encoding is not UTF-8.
Before / after
Before, burr test-case create, load_test_cases(), and StateAndResultsFullLogger opened text JSON files without an explicit encoding.
After, those reads/writes use encoding="utf-8", matching the rest of Burr's text-file handling and keeping non-ASCII fixture/log content deterministic across platforms.
Verification