_stream: Don't require runtime deps when building with --deps none #2102
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, running a build with `--deps none` would also build / pull runtime dependencies. This commit changes the elements on the command line to not require their runtime dependencies if we're using `--deps none`
abderrahim
requested review from
BenjaminSchubert,
cs-shadow,
gtristan and
juergbi
as code owners
In addition to `none` and `all`, this commit adds `run` and makes it the default instead of `none`. The previous commit changed the meaning of `--deps none` to be different from `--deps run`, so we change the default to be `run`.
Contributor
|
The proposed behavior seems reasonable. Looking at the documentation, the current I'd like to see at least minimal test coverage, though (could be a current test that is slightly expanded). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, running a build with
--deps nonewould also build / pull runtime dependencies. This commit changes the elements on the command line to not require their runtime dependencies if we're using--deps none.In addition to the config file option dependencies
noneandall, this PR addsrunand makes it thedefault instead of
none. The previous commit changed the meaning of--deps noneto be different from--deps run, so we change the default to berun.