skip return true if the end of the stream is reached#3242
Open
x1wan wants to merge 1 commit intoapache:masterfrom
Open
skip return true if the end of the stream is reached#3242x1wan wants to merge 1 commit intoapache:masterfrom
x1wan wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
LGTM |
chenBright
requested changes
Mar 13, 2026
| // reached or some input error occurred. In the end-of-stream case, the | ||
| // stream is advanced to the end of the stream (so ByteCount() will return | ||
| // the total size of the stream). | ||
| // Skips a number of bytes. Return false if some input error occurred. |
Contributor
There was a problem hiding this comment.
Please update the comment with protocolbuffers/protobuf@ab25c3e .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: 3207
Problem Summary: ParsePbFromIOBuf fail when skip reach the end of the stream
What is changed and the side effects?
Changed: skip return true if the end of the stream is reached
Side effects:
Performance effects: no effect
Breaking backward compatibility: no
Check List: