Open
Conversation
This handles removal of FieldDescriptor::is_optional()[^1] and ClassData removal of on_demand_register_arena_dtor[^2] [^1]: protocolbuffers/protobuf@9dbc5d4 [^2]: protocolbuffers/protobuf@49e15fe
There was a problem hiding this comment.
Pull request overview
This PR updates bRPC’s Protobuf integration points to compile with Protobuf v34+ (C++ 7.34.0), addressing upstream breaking API changes.
Changes:
- Replace removed
FieldDescriptor::is_optional()usage with equivalent logic based onis_required()/is_repeated(). - Add a new
GOOGLE_PROTOBUF_VERSION >= 7034000conditional initialization path forNonreflectableMessageclass metadata to account for removedon_demand_register_arena_dtor.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mcpack2pb/generator.cpp | Updates optional/required labeling logic to avoid removed is_optional() API. |
| src/json2pb/json_to_pb.cpp | Updates optional-field detection to avoid removed is_optional() API. |
| src/brpc/nonreflectable_message.h | Adds Protobuf 7.34+ ClassData initialization variant to match upstream internal layout changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: n/a
Problem Summary: Support building with Protobuf v34+ (C++ 7.34.0) which introduced breaking API changes.
What is changed and the side effects?
Changed:
FieldDescriptor::is_optional()following upstream recommendation at protocolbuffers/protobuf@9dbc5d4ClassDataason_demand_register_arena_dtorwas removed in protocolbuffers/protobuf@49e15feSide effects:
Performance effects:
Breaking backward compatibility: no
Check List: