Skip journal flush-trace loop when debug logging is disabled#4835
Open
merlimat wants to merge 1 commit into
Open
Skip journal flush-trace loop when debug logging is disabled#4835merlimat wants to merge 1 commit into
merlimat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After every journal flush, a second pass iterates the whole
toFlushlist purely to emit per-entry DEBUG trace lines. When DEBUG is disabled (the normal production configuration), the loop still runs: it allocates anIteratorper flush and walks the full list doing null checks for nothing.Changes
Wrap the trace loop in slog's lazy consumer form,
log.debug(e -> { ... }), which returns immediately without invoking the consumer when DEBUG is disabled — no iteration, no iterator. A local alias oftoFlushis captured since the field variable is reassigned after the hand-off to the force-write thread (not effectively final).Verified with
BookieJournalTestandBookieJournalForceTest(22/22 pass) and module checkstyle.