Skip to content

Use ThreadLocalRandom for thread selection in OrderedExecutor #4832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
merlimat wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

Use ThreadLocalRandom for thread selection in OrderedExecutor #4832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/OrderedExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@
import java.util.Collection;
import java.util.List;
import java.util.Map;
import java.util.Random;
import java.util.concurrent.Callable;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Future;
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.ThreadLocalRandom;
import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
Expand Down Expand Up @@ -65,7 +65,6 @@ public class OrderedExecutor implements ExecutorService {
final String name;
final ExecutorService[] threads;
final long[] threadIds;
final Random rand = new Random();
final OpStatsLogger taskExecutionStats;
final OpStatsLogger taskPendingStats;
final boolean traceTaskExecution;
Expand Down Expand Up @@ -545,7 +544,7 @@ public ExecutorService chooseThread() {
return threads[0];
}

return threads[rand.nextInt(threads.length)];
return threads[ThreadLocalRandom.current().nextInt(threads.length)];
}

public ExecutorService chooseThread(Object orderingKey) {
Expand All @@ -555,7 +554,7 @@ public ExecutorService chooseThread(Object orderingKey) {
}

if (null == orderingKey) {
return threads[rand.nextInt(threads.length)];
return threads[ThreadLocalRandom.current().nextInt(threads.length)];
} else {
return threads[chooseThreadIdx(orderingKey.hashCode(), threads.length)];
}
Expand Down
Loading