Skip to content

Fix DataflowV1 test failure by fixing getSimpleName access#39330

Open
Abacn wants to merge 2 commits into
masterfrom
fix-reflect
Open

Fix DataflowV1 test failure by fixing getSimpleName access#39330
Abacn wants to merge 2 commits into
masterfrom
fix-reflect

Conversation

@Abacn

@Abacn Abacn commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Please add a meaningful description for your change here

Tested in https://github.com/apache/beam/actions/runs/29358766897


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues encountered in Java 17+ environments where accessing the simple name of certain non-public inner classes triggers an IllegalAccessError. By centralizing class name retrieval through a new robust utility method, the changes ensure that the codebase remains resilient to these reflection-related restrictions while maintaining existing functionality.

Highlights

  • Robust Class Name Resolution: Introduced a new utility method ReflectHelpers.getSimpleName(Class) to safely retrieve class names, providing a fallback mechanism when Class.getSimpleName() throws exceptions like IllegalAccessError on newer Java versions.
  • Compatibility Fixes: Updated multiple locations in DisplayData, DoFnSignatures, and ReflectHelpers to use the new safe getSimpleName utility, ensuring compatibility with Java 17+ environments where non-public inner class access can be restricted.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a helper method ReflectHelpers.getSimpleName(Class<?>) to safely retrieve the simple name of a class, preventing potential exceptions (such as IllegalAccessError on Java 17+ for non-public inner classes) by falling back to parsing the class name. Direct calls to Class.getSimpleName() are replaced with this helper across several files. Feedback on the changes highlights that the fallback logic does not correctly handle array types of non-public inner classes (e.g., returning "Inner;" instead of "Inner[]") and suggests a recursive approach to handle arrays properly.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants