Skip to content

Make FirestoreV1 Transform bases public for worker access #39324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aIbrahiim wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −7
Draft

Make FirestoreV1 Transform bases public for worker access #39324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/trigger_files/beam_PostCommit_Java_DataflowV1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
"https://github.com/apache/beam/pull/35177": "Introducing WindowedValueReceiver to runners",
"comment": "Modify this file in a trivial way to cause this test suite to run",
"modification": 9,
"modification": 10,
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface"
}
12 changes: 6 additions & 6 deletions ...google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreV1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,7 +1410,7 @@ private void emit(ProcessContext c, String dbRoot, StructuredQuery.Builder build
}

/** DoFn to output CollectionIds from a {@link ListCollectionIdsResponse}. */
private static final class FlattenListCollectionIdsResponse
static final class FlattenListCollectionIdsResponse
extends DoFn<ListCollectionIdsResponse, String> {
@ProcessElement
public void processElement(ProcessContext c) {
Expand All @@ -1419,7 +1419,7 @@ public void processElement(ProcessContext c) {
}

/** DoFn to output {@link Document}s from a {@link ListDocumentsResponse}. */
private static final class ListDocumentsResponseToDocument
static final class ListDocumentsResponseToDocument
extends DoFn<ListDocumentsResponse, Document> {
@ProcessElement
public void processElement(ProcessContext c) {
Expand Down Expand Up @@ -1826,7 +1826,7 @@ public List<WriteFailure> getWriteFailures() {
* @param <BldrT> The type of the type safe builder which is used to build and instance of {@link
* TrfmT}
*/
private abstract static class Transform<
public abstract static class Transform<
InT extends PInput,
OutT extends POutput,
TrfmT extends Transform<InT, OutT, TrfmT, BldrT>,
Expand Down Expand Up @@ -1880,7 +1880,7 @@ public final void populateDisplayData(DisplayData.Builder builder) {
* @param <BldrT> The type of the type safe builder which is used to build and instance of
* {@link TrfmT}
*/
abstract static class Builder<
public abstract static class Builder<
InT extends PInput,
OutT extends POutput,
TrfmT extends Transform<InT, OutT, TrfmT, BldrT>,
Expand Down Expand Up @@ -2018,7 +2018,7 @@ String getDatabaseId() {
}
}

private abstract static class ReadTransform<
public abstract static class ReadTransform<
InT extends PInput,
OutT extends POutput,
TrfmT extends ReadTransform<InT, OutT, TrfmT, BldrT>,
Expand All @@ -2041,7 +2041,7 @@ private abstract static class ReadTransform<
@Override
public abstract BldrT toBuilder();

abstract static class Builder<
public abstract static class Builder<
InT extends PInput,
OutT extends POutput,
TrfmT extends ReadTransform<InT, OutT, TrfmT, BldrT>,
Expand Down
Loading