Skip to content

add jdkAddOpenModules for Dataflow V2#39306

Open
aIbrahiim wants to merge 2 commits into
apache:masterfrom
aIbrahiim:dataflow-v2-jdkAddOpenModules-arrow
Open

add jdkAddOpenModules for Dataflow V2#39306
aIbrahiim wants to merge 2 commits into
apache:masterfrom
aIbrahiim:dataflow-v2-jdkAddOpenModules-arrow

Conversation

@aIbrahiim

@aIbrahiim aIbrahiim commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Fixes: #39274

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@aIbrahiim aIbrahiim marked this pull request as ready for review July 14, 2026 06:51
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Dataflow V2 runner configuration to include necessary JDK module access flags, specifically opening java.nio to all unnamed modules. This change is intended to resolve compatibility issues when running Dataflow V2 pipelines, while also updating the associated CI trigger file to reflect the configuration change.

Highlights

  • Configuration Update: Added the jdkAddOpenModules flag to the Dataflow V2 runner configuration to allow access to java.nio modules.
  • CI Trigger Update: Incremented the modification counter in the Dataflow V2 post-commit trigger file.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increments the modification trigger version for Dataflow V2 and adds the --jdkAddOpenModules=java.base/java.nio=ALL-UNNAMED JVM option to the common pipeline options for Runner V2 in the Google Cloud Dataflow runner build configuration. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @tvalentyn added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn

Abacn commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Since this error is user-facing when they use Dataflow runner + BigQuery with Arrow, can we explore if we can add this (java.base/java.nio=ALL-UNNAMED) to SDK harness' open module agent

https://github.com/apache/beam/blob/a6f2ff42e9e6c6e14c81693f3f9643be506719dd/sdks/java/container/agent/src/main/java/org/apache/beam/agent/OpenModuleAgent.java

so user would not need to config same options as here?

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.76%. Comparing base (cccb649) to head (5b4b2f1).
⚠️ Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #39306   +/-   ##
=========================================
  Coverage     54.76%   54.76%           
  Complexity     1716     1716           
=========================================
  Files          1066     1066           
  Lines        169067   169067           
  Branches       1255     1255           
=========================================
  Hits          92592    92592           
  Misses        74258    74258           
  Partials       2217     2217           
Flag Coverage Δ
go 28.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aIbrahiim

Copy link
Copy Markdown
Contributor Author

Since this error is user-facing when they use Dataflow runner + BigQuery with Arrow, can we explore if we can add this (java.base/java.nio=ALL-UNNAMED) to SDK harness' open module agent

https://github.com/apache/beam/blob/a6f2ff42e9e6c6e14c81693f3f9643be506719dd/sdks/java/container/agent/src/main/java/org/apache/beam/agent/OpenModuleAgent.java

so user would not need to config same options as here?

I checked OpenModuleAgent and it only opens modules to jamm so it can't do ALL-UNNAMED the way Arrow needs so I added a container meta option instead so the harness gets --add-opens=java.base/java.nio=ALL-UNNAMED by default and the workflow passed with this. @Abacn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Java Dataflow V2 job is flaky

2 participants