Skip to content

Revert "[Python] Honor disableCounterMetrics, disableStringSetMetrics, and disableBoundedTrieMetrics experiments"#38901

Merged
Abacn merged 2 commits into
masterfrom
revert-38749-py-disable-user-metrics-38746
Jun 10, 2026
Merged

Revert "[Python] Honor disableCounterMetrics, disableStringSetMetrics, and disableBoundedTrieMetrics experiments"#38901
Abacn merged 2 commits into
masterfrom
revert-38749-py-disable-user-metrics-38746

Conversation

@Abacn

@Abacn Abacn commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Reverts #38749

See #38749 (comment), and there are other breakages breaking internal imports

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous change that allowed users to disable specific metric types (Counter, StringSet, and BoundedTrie) via pipeline experiments. The reversion was necessary to resolve issues with internal imports and other breakages caused by the original implementation. The codebase has been cleaned up to remove the MetricsFlag class and all associated logic and tests.

Highlights

  • Reversion of Metrics Flag Functionality: Reverted the changes that introduced MetricsFlag and the ability to disable specific metric types (Counter, StringSet, BoundedTrie) via pipeline experiments, due to internal import issues and breakages.
  • Cleanup of Metrics Logic: Removed the MetricsFlag class and associated logic from metric.py, and updated DelegatingCounter, DelegatingStringSet, and DelegatingBoundedTrie to remove the conditional checks for disabled metrics.
  • Removal of Pipeline Integration: Cleaned up references to MetricsFlag in pipeline.py, sdk_worker_main.py, and metric_test.py, ensuring that the initialization of pipeline options no longer attempts to set these flags.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Abacn

Abacn commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

R: @damccorm

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the MetricsFlag class and the associated logic for disabling specific metric types (counters, string sets, and bounded tries) via pipeline options, simplifying the delegating metric classes. A review comment identifies an incorrect docstring in DelegatingBoundedTrie that refers to StringSet instead of BoundedTrie.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sdks/python/apache_beam/metrics/metric.py Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn Abacn merged commit 02168d3 into master Jun 10, 2026
104 of 105 checks passed
@Abacn Abacn deleted the revert-38749-py-disable-user-metrics-38746 branch June 10, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants