Skip to content

Fix ml_test protobuf conflict for Yaml Xlang Direct#38890

Merged
damccorm merged 1 commit into
apache:masterfrom
aIbrahiim:fix/beam_PostCommit_Yaml_Xlang_Direct-tf2onnx
Jun 11, 2026
Merged

Fix ml_test protobuf conflict for Yaml Xlang Direct#38890
damccorm merged 1 commit into
apache:masterfrom
aIbrahiim:fix/beam_PostCommit_Yaml_Xlang_Direct-tf2onnx

Conversation

@aIbrahiim

@aIbrahiim aIbrahiim commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Fixes: #35198

I used p310_ml_test,yaml instead of ml_test,yaml same as #38798 did for PreCommit because ml_test pulls tft/tf2onnx 1.16.x (protobuf < 4), which clashes with GCP deps needing protobuf ≥ 4.25.8 under uv. p310_ml_test avoids that chain

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@aIbrahiim aIbrahiim force-pushed the fix/beam_PostCommit_Yaml_Xlang_Direct-tf2onnx branch from d183b20 to ac25dbc Compare June 10, 2026 15:28
@github-actions github-actions Bot removed the python label Jun 10, 2026
@aIbrahiim

Copy link
Copy Markdown
Contributor Author

cc: @derrickaw

@aIbrahiim aIbrahiim marked this pull request as ready for review June 10, 2026 16:09
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a dependency conflict involving protobuf versions in the Yaml Xlang Direct test suite. By switching to a different test configuration, the build avoids incompatible version requirements between older ML libraries and current GCP dependencies, ensuring stable test execution.

Highlights

  • Test Configuration Update: Updated the revision number in the Yaml Xlang Direct post-commit trigger file to ensure the test suite runs correctly.
  • Dependency Conflict Resolution: Switched to p310_ml_test.yaml to avoid protobuf version conflicts between legacy ML dependencies and modern GCP requirements.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/beam_PostCommit_Yaml_Xlang_Direct.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@aIbrahiim

Copy link
Copy Markdown
Contributor Author

assign set of reviewers

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit 61a7368 into apache:master Jun 11, 2026
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit YAML Xlang Direct job is flaky

2 participants