Skip to content

Fix MatchContinuously translation#38850

Merged
ahmedabu98 merged 1 commit into
apache:masterfrom
ahmedabu98:matchcontinuously_translate_fix
Jun 8, 2026
Merged

Fix MatchContinuously translation#38850
ahmedabu98 merged 1 commit into
apache:masterfrom
ahmedabu98:matchcontinuously_translate_fix

Conversation

@ahmedabu98

Copy link
Copy Markdown
Contributor

I was trying to use Python's apache_beam.io.fileio.MatchContinuously in a YAML pipeline that had a downstream Java sink, and kept running into this error:

TypeError: no default __reduce__ due to non-trivial __cinit__
...

RuntimeError: Unable to translate MatchContinuously/GetFilePattern

This fix allows MatchContinuously to get translated normally. Just needed to use a local variable to avoid having to serialize self


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a serialization issue in the Apache Beam Python SDK's MatchContinuously transform. By decoupling the file pattern from the class instance during the mapping process, the transform can now be correctly translated for cross-language pipelines, resolving runtime errors encountered when integrating with Java-based sinks.

Highlights

  • Serialization Fix: Modified the MatchContinuously transform to use a local variable for the file pattern, preventing the need to serialize the entire self object during pipeline translation.
  • Bug Resolution: Resolved a TypeError and RuntimeError occurring when using MatchContinuously in YAML pipelines with downstream Java sinks.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ahmedabu98

Copy link
Copy Markdown
Contributor Author

R: @chamikaramj

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the MatchContinuously transform in sdks/python/apache_beam/io/fileio.py by extracting self.file_pattern into a local variable before using it inside the lambda function. This is a standard practice in Apache Beam to avoid serializing the entire class instance (self) when executing the pipeline. There are no review comments to evaluate, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@chamikaramj

Copy link
Copy Markdown
Contributor

LGTM. Thanks!

@ahmedabu98 ahmedabu98 merged commit d521df8 into apache:master Jun 8, 2026
101 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants