Skip to content

Revert "Update transform catalogue docs"#38728

Closed
aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:revert-38457-update-docs
Closed

Revert "Update transform catalogue docs"#38728
aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:revert-38457-update-docs

Conversation

@aIbrahiim
Copy link
Copy Markdown
Contributor

Reverts #38457 to unblock Playground CI

The added BatchElementsExample uses org.apache.beam.sdk.transforms.BatchElements which is only available on upcoming release so we will add it back after the release.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts the recent addition of the BatchElements transform documentation and example code. The change is necessary to unblock the Playground CI, as the underlying transform functionality is currently only available in an upcoming release. Additionally, minor code cleanup was performed within the BatchElements implementation to improve maintainability.

Highlights

  • Reversion of BatchElements documentation: Removed the BatchElements example and associated documentation to unblock the Playground CI, as the feature relies on an upcoming release.
  • Code cleanup in BatchElements: Simplified the BatchElements transform implementation by removing unused imports and updating the output method to use outputWithTimestamp.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the BatchElements transform in the Java SDK by replacing receiver.outputWindowedValue with receiver.outputWithTimestamp and removing unused imports. It also removes the BatchElements example, documentation, and website menu references. There are no review comments, so I have no feedback to provide.

@aIbrahiim
Copy link
Copy Markdown
Contributor Author

cc: @damccorm @Abacn @ganesh-skumar

Copy link
Copy Markdown
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of reverting the whole PR, can we just remove the example which is causing the failures (or maybe even just the playground portion)? Then we can unrevert it after the next release

@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented May 28, 2026

Minimun change need to bring playground ci test green would be remove the playground annotations for now

https://github.com/aIbrahiim/beam/blob/0302bf5529cda834cfabed642e6e8e5373d5a65f/examples/java/src/main/java/org/apache/beam/examples/BatchElementsExample.java#L32

@aIbrahiim aIbrahiim closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants