[Release-2.74] Cherry-pick #38695 into release branch#38727
Conversation
…OnHeartbeat (apache#38695) This meant that low latency mode for heartbeats was enabled by default and disabled in low latency mode instead of the desired opposite.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a cherry-pick of a bug fix from the main branch into the release-2.74 branch. The change corrects the conditional logic governing how heartbeat records handle process continuation, ensuring that the system behaves as expected when query cancellation is configured. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request inverts the ternary logic in HeartbeatRecordAction.java when returning a ProcessContinuation based on the cancelQueryOnHeartbeat flag. It now returns Optional.of(ProcessContinuation.resume()) when the flag is true, and Optional.empty() when it is false. The corresponding unit tests in HeartbeatRecordActionTest.java have been updated to reflect this change. There are no review comments to address.
upgrade gradle action to enable the CI - 5.0.0 was removed by apache/infrastructure-actions@9ef334e
|
R: @aIbrahiim |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
PreCommit Java GCP IO Direct is green on HEAD with this change, merging for now. Have another cherry-pick PR also going to test with |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.