Implements the Delta Lake source with support for splitting#38706
Implements the Delta Lake source with support for splitting#38706chamikaramj wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a native Delta Lake source for Apache Beam, allowing users to read Delta tables efficiently. It introduces a task-based approach to file reading, grouping files into 1GB tasks, and leverages Splittable DoFns to enable dynamic work rebalancing at the row-group level. The implementation integrates with the Delta Kernel Engine and includes comprehensive testing for serialization and data reading. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
c260afe to
6a52b00
Compare
There was a problem hiding this comment.
Code Review
This pull request implements Delta Lake reading capabilities within the Apache Beam Java SDK. It introduces a custom BeamEngine and BeamParquetHandler to integrate Delta Kernel's engine with Beam's RestrictionTracker for row group claiming. It also adds CreateReadTasksDoFn to plan read tasks, DeltaSourceDoFn as a splittable DoFn to process logical reads, and serialization wrappers (SerializableRow, SerializableStructType). Feedback focuses on performance optimizations—such as caching Hadoop configurations and task metadata to avoid duplicate Parquet footer reads—and resource safety improvements to ensure closeable iterators are properly closed even when exceptions occur.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #38706 +/- ##
============================================
+ Coverage 56.40% 58.08% +1.67%
- Complexity 3803 12943 +9140
============================================
Files 1316 2511 +1195
Lines 181666 262251 +80585
Branches 2586 10655 +8069
============================================
+ Hits 102464 152319 +49855
- Misses 76359 104230 +27871
- Partials 2843 5702 +2859
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds a
DeltaReadTasksDoFn, that groups files into 1 GBDeltaReadTasks.Adds a SDF,
DeltaSourceDoFnthat implements the functionality for reading aPCollectionofDeltaReadTasks.Adds a
RangeTracker,DeltaReadTaskTracker, that can be used to track a range of row groups that belong to a givenDeltaReadTask.Adds
BeamParquetHandlerthat implements the Delta Kernel Engine APIParquetHandlerto perform reading and splitting considering correct row group ranges.For additional context, please see the design https://s.apache.org/beam-delta-lake-source.
This fixes #38551.
This fixes #38552.
This fixes #38553.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.