[Dataflow Streaming] Enable state tag encoding v2#38705
Conversation
502a659 to
1e0186c
Compare
…gine jobs Also added CHANGES.md entry detailing the change, how to disable it, and job update/downgrade limitations.
|
R: @scwhittle |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enables state tag encoding v2 by default for new Dataflow Streaming Engine jobs in the Java SDK. This change improves state handling efficiency but introduces specific compatibility requirements for job updates and version downgrades, which are now documented in the project changelog. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enables state tag encoding v2 by default for new Dataflow Streaming Engine jobs in the Java SDK and documents this change in the release notes. A review comment points out that we should avoid adding the enable_streaming_engine_state_tag_encoding_v2 experiment if the user has explicitly disabled it via disable_streaming_engine_state_tag_encoding_v2 to prevent sending conflicting experiments to the Dataflow backend.
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
| experiments.add("streaming_engine_state_tag_encoding_v2_supported"); | ||
| // Experiment requesting tag encoding v2 on new jobs. During job updates | ||
| // old job's tag encoding version is carried over by the backend. | ||
| experiments.add("enable_streaming_engine_state_tag_encoding_v2"); |
There was a problem hiding this comment.
I think we should respect the update compatability beam option as well, if that is requesting a lower version it should not enable this so that update compatability with the older version works. see updateCompatibilityVersionLessThan
No description provided.