Skip to content

[Dataflow Streaming] Enable state tag encoding v2#38705

Open
arunpandianp wants to merge 1 commit into
apache:masterfrom
arunpandianp:enableTagV2
Open

[Dataflow Streaming] Enable state tag encoding v2#38705
arunpandianp wants to merge 1 commit into
apache:masterfrom
arunpandianp:enableTagV2

Conversation

@arunpandianp
Copy link
Copy Markdown
Contributor

No description provided.

@arunpandianp arunpandianp force-pushed the enableTagV2 branch 2 times, most recently from 502a659 to 1e0186c Compare May 27, 2026 16:23
…gine jobs

Also added CHANGES.md entry detailing the change, how to disable it, and job update/downgrade limitations.
@arunpandianp arunpandianp marked this pull request as ready for review May 27, 2026 16:33
@arunpandianp
Copy link
Copy Markdown
Contributor Author

R: @scwhittle

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enables state tag encoding v2 by default for new Dataflow Streaming Engine jobs in the Java SDK. This change improves state handling efficiency but introduces specific compatibility requirements for job updates and version downgrades, which are now documented in the project changelog.

Highlights

  • State Tag Encoding v2: Enabled state tag encoding v2 by default for new Dataflow Streaming Engine jobs.
  • Pipeline Configuration: Added the ability to disable the new encoding via the --experiments=disable_streaming_engine_state_tag_encoding_v2 pipeline option.
  • Documentation: Updated CHANGES.md to reflect the new feature and associated constraints regarding job updates and version compatibility.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables state tag encoding v2 by default for new Dataflow Streaming Engine jobs in the Java SDK and documents this change in the release notes. A review comment points out that we should avoid adding the enable_streaming_engine_state_tag_encoding_v2 experiment if the user has explicitly disabled it via disable_streaming_engine_state_tag_encoding_v2 to prevent sending conflicting experiments to the Dataflow backend.

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

experiments.add("streaming_engine_state_tag_encoding_v2_supported");
// Experiment requesting tag encoding v2 on new jobs. During job updates
// old job's tag encoding version is carried over by the backend.
experiments.add("enable_streaming_engine_state_tag_encoding_v2");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should respect the update compatability beam option as well, if that is requesting a lower version it should not enable this so that update compatability with the older version works. see updateCompatibilityVersionLessThan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants