Disable build isolation for pip by default in boot.go of Python containers#38700
Disable build isolation for pip by default in boot.go of Python containers#38700shunping wants to merge 1 commit into
Conversation
Users can re-enable it by using experiment "pip_use_build_isolation".
|
r: @damccorm |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the default configuration for pip package installation within Python containers to disable build isolation. This change is intended to streamline the installation process and address common dependency resolution issues, while maintaining backward compatibility for users who specifically require build isolation through the newly introduced experiment flag. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request changes the default behavior of pip's build isolation in the Python SDK container boot process. It switches the default to disabling build isolation (pipNoBuildIsolation = true) unless the experiment pip_use_build_isolation is explicitly specified. The reviewer suggested simplifying the assignment logic for pipNoBuildIsolation to improve readability and eliminate redundant assignments.
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Thanks! |
Users can re-enable it by using experiment "pip_use_build_isolation"
See https://lists.apache.org/thread/cqpkp8h2clqkj1jd0vtgc4fxocxytfvy for context and discussion.