Skip to content

Disable build isolation for pip by default in boot.go of Python containers#38700

Open
shunping wants to merge 1 commit into
apache:masterfrom
shunping:disable-build-isolation
Open

Disable build isolation for pip by default in boot.go of Python containers#38700
shunping wants to merge 1 commit into
apache:masterfrom
shunping:disable-build-isolation

Conversation

@shunping
Copy link
Copy Markdown
Collaborator

@shunping shunping commented May 26, 2026

Users can re-enable it by using experiment "pip_use_build_isolation"

See https://lists.apache.org/thread/cqpkp8h2clqkj1jd0vtgc4fxocxytfvy for context and discussion.

Users can re-enable it by using experiment "pip_use_build_isolation".
@shunping shunping changed the title Disable build isolation for pip by default. Disable build isolation for pip by default in boot.go of Python containers May 26, 2026
@shunping
Copy link
Copy Markdown
Collaborator Author

r: @damccorm

@shunping shunping marked this pull request as ready for review May 26, 2026 23:45
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the default configuration for pip package installation within Python containers to disable build isolation. This change is intended to streamline the installation process and address common dependency resolution issues, while maintaining backward compatibility for users who specifically require build isolation through the newly introduced experiment flag.

Highlights

  • Default behavior change: Updated the Python container boot process to disable pip build isolation by default.
  • Experiment flag update: Replaced the previous opt-out flag with a new opt-in experiment flag, pip_use_build_isolation, to allow users to re-enable build isolation when necessary.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request changes the default behavior of pip's build isolation in the Python SDK container boot process. It switches the default to disabling build isolation (pipNoBuildIsolation = true) unless the experiment pip_use_build_isolation is explicitly specified. The reviewer suggested simplifying the assignment logic for pipNoBuildIsolation to improve readability and eliminate redundant assignments.

Comment thread sdks/python/container/boot.go
@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damccorm
Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants