[AURON #2407] [BUILD] Fix the invalid Spark 4.1 Docker build example.#2408
Open
slfan1989 wants to merge 1 commit into
Open
[AURON #2407] [BUILD] Fix the invalid Spark 4.1 Docker build example.#2408slfan1989 wants to merge 1 commit into
slfan1989 wants to merge 1 commit into
Conversation
…ample. Signed-off-by: slfan1989 <slfan1989@apache.org>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the build documentation and auron-build.sh --help output to provide valid, Spark-version-specific Docker build examples (notably avoiding Spark 4.x with centos7/JDK 8 and excluding incompatible integrations), and adds a documented compatibility matrix for contributors.
Changes:
- Update
CONTRIBUTING.mdDocker example to userockylinux8and add a build compatibility matrix covering Spark/Scala/JDK/image and integration combinations. - Update
auron-build.sh --helpto print separate Docker build examples for Spark 3.5, 4.0, and 4.1 with compatible Scala/JDK/image/integration selections.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CONTRIBUTING.md | Updates Docker build example and adds a build compatibility matrix documenting supported combinations. |
| auron-build.sh | Replaces the single Docker example in --help with explicit, Spark-version-specific Docker build examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
83
to
84
| "--iceberg ${SUPPORTED_ICEBERG_VERSIONS[*]: -1}" \ | ||
| "--hudi ${SUPPORTED_HUDI_VERSIONS[*]: -1}" |
| "--celeborn ${SUPPORTED_CELEBORN_VERSIONS[*]: -1}" \ | ||
| "--uniffle ${SUPPORTED_UNIFFLE_VERSIONS[*]: -1}" \ | ||
| "--paimon ${SUPPORTED_PAIMON_VERSIONS[*]: -1}" \ | ||
| "--iceberg ${SUPPORTED_ICEBERG_VERSIONS[*]: -1}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2407
Rationale for this change
The Docker build example generated by
auron-build.sh --helpused Spark 4.1 together with thecentos7image.The
centos7image only provides JDK 8, while Spark 4.x requires JDK 17 or later. The example also enabled Iceberg and Hudi for Spark versions with which those integrations are not compatible.As a result, users following the documented example encountered Java version or integration compatibility errors before completing the build.
What changes are included in this PR?
Spark 3.5, Spark 4.0, and Spark 4.1.
rockylinux8image for these examples because it supports theJDK selection required by Spark 4.x.
CONTRIBUTING.md.Uniffle, Paimon, Iceberg, and Hudi combinations.
CONTRIBUTING.mdto userockylinux8.be updated together.
Are there any user-facing changes?
Yes.
The help output now provides separate Docker build examples for Spark
3.5, Spark 4.0, and Spark 4.1. Each example uses an appropriate Scala,
JDK, Docker image, and third-party integration combination.
Contributors can also consult the compatibility matrix in
CONTRIBUTING.mdbefore selecting build arguments.How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
If yes, include:
Generated-by: <tool name and version>ASF guidance: https://www.apache.org/legal/generative-tooling.html