ARTEMIS-6141 Fix non-portable kill -SIGINT#6558
Merged
Merged
Conversation
LargeMessageInterruptTest.killProcess() relies on Runtime.exec("kill -SIGINT ...")
to send a graceful shutdown signal. The -SIGINT flag is a non-standard signal
specification that some kill implementations silently ignore while reporting
success (exit code 0), causing the broker process to stay alive and the test
to time out. Observed on Fedora 43 where /usr/bin/kill does not handle -SIGINT.
Replace with Process.destroy() which sends SIGTERM directly via JVM syscall,
with no dependency on external binaries or their flag parsing behavior.
Assisted-by: Cursor
lavocatt
force-pushed
the
fix-sigint-kill-upstream
branch
from
c2619f9 to
ce97e7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LargeMessageInterruptTest.killProcess() relies on Runtime.exec("kill -SIGINT ...") to send a graceful shutdown signal. The -SIGINT flag is a non-standard signal specification that some kill implementations silently ignore while reporting success (exit code 0), causing the broker process to stay alive and the test to time out. Observed on Fedora 43 where /usr/bin/kill does not handle -SIGINT.
Replace with Process.destroy() which sends SIGTERM directly via JVM syscall, with no dependency on external binaries or their flag parsing behavior.