-
Notifications
You must be signed in to change notification settings - Fork 953
ARTEMIS-6130 Clarify artemis check queue command options #6544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brusdev
wants to merge
1
commit into
apache:main
Choose a base branch
from
brusdev:ARTEMIS-6130
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,10 +37,10 @@ public class QueueCheck extends CheckAbstract { | |
| @Option(names = "--up", description = "Check that the queue exists and is not paused. This check is executed by default if there are no other checks.") | ||
| private boolean up; | ||
|
|
||
| @Option(names = "--browse", description = "Number of the messages to browse or -1 to check that the queue is browsable.") | ||
| @Option(names = "--browse", description = "Number of the messages to browse or -1 to browse at most 1 message only if it is immediately available (succeeding also if no messages are available).") | ||
| private Integer browse; | ||
|
|
||
| @Option(names = "--consume", description = "Number of the messages to consume or -1 to check that the queue is consumable.") | ||
| @Option(names = "--consume", description = "Number of the messages to consume or -1 to consume at most 1 message only if it is immediately available (succeeding also if no messages are available).") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here |
||
| private Integer consume; | ||
|
|
||
| @Option(names = "--produce", description = "Number of the messages to produce.") | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brusdev Is there a default value? perhaps you could specify (default = X) on the description).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, at least not through the cli. You must pass the

--consumevalue. If you don't, you'll get an error.If you pass a value lower than

-1, you'll get an error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm there is no default value. @clebertsuconic are you suggesting adding a default value?