ARTEMIS-5069 / ARTEMIS-5068 Temporary queues are going through mirroring#6301
ARTEMIS-5069 / ARTEMIS-5068 Temporary queues are going through mirroring#6301clebertsuconic wants to merge 1 commit intoapache:mainfrom
Conversation
|
Notice the test I wrote here will most likely fail until #6300 is merged |
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/AddressInfo.java
Outdated
Show resolved
Hide resolved
...is-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RoutingContextImpl.java
Outdated
Show resolved
Hide resolved
clebertsuconic
force-pushed
the
ARTEMIS-5069
branch
4 times, most recently
from
1e19209 to
312febb
Compare
|
The title and commit log message reference a non-existent Jira. |
clebertsuconic
force-pushed
the
ARTEMIS-5069
branch
from
312febb to
fc3682c
Compare
clebertsuconic
changed the title
|
@gemmellr nice catch on my typo... 9 is next to 0... I hit the wrong key by accident :) |
Mirroring should ignore send / create / delete / acks for temporary queues
clebertsuconic
force-pushed
the
ARTEMIS-5069
branch
from
fc3682c to
be4a24d
Compare
| } | ||
|
|
||
| @Test | ||
| public void testNoTemporaryQueues() throws Exception { |
There was a problem hiding this comment.
The test is named testNoTemporaryQueues but its creating temporary topics. It would be nice to create a set of tests that exercise both to ensure the two domains are covered in testing for the mirror. Should be simple enough the create on method that does one type of the other and call it with an option.
There was a problem hiding this comment.
I don't think it matters on this case... it's a temporary queue from the internal POV. but I will add the test
3 participants
Mirroring should ignore send / create / delete / acks for temporary queues