ARTEMIS-5852 Leader/Follower pattern on acceptors #6191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebertsuconic
force-pushed
the
lock
branch
18 times, most recently
from
3e76798 to
940e9c4
Compare
tabish121
reviewed
Jan 26, 2026
...ain/java/org/apache/activemq/artemis/lockmanager/etcd/EtcdDistributedLockManagerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/activemq/artemis/lockmanager/file/FileBasedLockManagerFactory.java
Outdated
Show resolved
Hide resolved
.../org/apache/activemq/artemis/lockmanager/zookeeper/CuratorDistributedLockManagerFactory.java
Outdated
Show resolved
Hide resolved
clebertsuconic
force-pushed
the
lock
branch
7 times, most recently
from
3367529 to
8372c9c
Compare
Contributor
Author
|
I just split this into 2 commits. they are still in the same PR as the etcd still depending on the first commit. |
clebertsuconic
force-pushed
the
lock
branch
3 times, most recently
from
521369c to
cc8ee7d
Compare
Contributor
Author
|
@gtully it should work with broker properties, but I don't have a test yet... |
Contributor
Author
|
jdbc can be done.. but it would be a future task.. I wouldn't hold this for now. |
clebertsuconic
force-pushed
the
lock
branch
3 times, most recently
from
f5024bb to
48ea524
Compare
clebertsuconic
force-pushed
the
lock
branch
8 times, most recently
from
92763c4 to
36313f5
Compare
clebertsuconic
force-pushed
the
lock
branch
8 times, most recently
from
3bc3d5a to
06a760d
Compare
Contributor
Author
|
@gtully I have fixed the usage of broker properties, and simplified this quite a lot. I intended to write documentation today but I got stuck on removing etcd and the needed cleanup after removing it. |
clebertsuconic
force-pushed
the
lock
branch
4 times, most recently
from
31c7fab to
8a83588
Compare
I'm adding a LeaderManager to the broker, that will use DistributedLock to determine the node that will be the lead. You can associate the leaderManager with acceptors and an acceptor serving only clients would then be activated in only one of the brokers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding a LeaderManager to the broker, that will use DistributedLock to determine the node that will be the lead.
You can associate the leaderManager with acceptors and an acceptor serving only clients would then be activated in only one of the brokers.