GH-50637: [C++] Register Abseil bundled static libraries in build_absl()#50643
Closed
KHARSHAVARDHAN-eng wants to merge 1 commit into
Closed
GH-50637: [C++] Register Abseil bundled static libraries in build_absl()#50643KHARSHAVARDHAN-eng wants to merge 1 commit into
KHARSHAVARDHAN-eng wants to merge 1 commit into
Conversation
…ld_absl() instead of build_protobuf() Currently, Abseil bundled static libraries (`absl::...`) are registered in `ARROW_BUNDLED_STATIC_LIBS` inside `build_protobuf()` within an `if(CMAKE_CROSSCOMPILING)` block. This moves the Abseil bundled static library target registration to `build_absl()`, ensuring Abseil targets are always registered when building Abseil from source and decoupling Abseil registration from `build_protobuf()`. Closes: apache#50637
|
|
Contributor
|
A PR (#50638) for this issue has already been opened and is currently under review. Since this issue is already being addressed, could you close this PR? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Bundled Abseil static library targets (
absl::...) are currently registered inARROW_BUNDLED_STATIC_LIBSfrombuild_protobuf()under theCMAKE_CROSSCOMPILINGcode path.Since these targets belong to Abseil, their registration is more appropriately owned by
build_absl(). Moving the registration there removes the coupling between Abseil target registration and Protobuf, while ensuring the bundled Abseil targets are registered whenever Abseil is built from source.Closes: #50637
What changes are included in this PR?
absl::...) frombuild_protobuf()tobuild_absl().ARROW_BUNDLED_STATIC_LIBSfrombuild_absl()usingPARENT_SCOPE.build_protobuf().Are these changes tested?
Yes.
arrow_staticwith bundled dependencies enabled (ARROW_DEPENDENCY_SOURCE=BUNDLED).ArrowConfig.cmakecontains the expected bundled Abseil targets followed byprotobuf::libprotobuf.CMAKE_CROSSCOMPILING.Are there any user-facing changes?
No.
This change only affects the internal CMake dependency registration logic used when building bundled dependencies.
build_protobuf()instead ofbuild_absl()#50637