GH-49046: [Dev][Python] Remove unused scripts under python/scripts#50640
Open
GujaLomsadze wants to merge 1 commit into
Open
GH-49046: [Dev][Python] Remove unused scripts under python/scripts#50640GujaLomsadze wants to merge 1 commit into
GujaLomsadze wants to merge 1 commit into
Conversation
test_imports.py and test_leak.py are leftovers from an older test layout. Neither is referenced by CI, packaging or the pytest suite, and neither is documented. Their test_-prefixed names have also caused accidental pytest collection in the past (ARROW-1033). The remaining scripts in that directory are untouched: run_emscripten_tests.py is invoked from ci/scripts/python_test_emscripten.sh, and update_stub_docstrings.py is used to refresh type stub docstrings.
|
|
Contributor
Author
|
This removes both scripts, matching the direction in the issue (#49046) test_leak.py was mentioned as potentially useful as a snippet showing how to check for leaks, if documented. This PR removes it, following the "I would probably remove them" comment. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Resolves #49046
python/scripts/test_imports.pyandpython/scripts/test_leak.pyare leftovers from an oldertest layout. They are not referenced by CI, packaging or the pytest suite, and are not
documented anywhere. Their
test_-prefixed names have also caused accidental pytest collectionin the past (ARROW-1033). This follows the suggestion on the issue to remove them.
Deletes
python/scripts/test_imports.pyandpython/scripts/test_leak.py.The other two scripts in that directory are untouched and still in use:
run_emscripten_tests.py(invoked fromci/scripts/python_test_emscripten.sh) andupdate_stub_docstrings.py.The issue description raised the option of keeping
test_leak.pyas a documented snippet forchecking leaks. This PR removes it, following the later comment. Happy to restore and document
it under the developer docs instead if reviewers prefer.
Are these changes tested?
No new tests, this only removes files that nothing references. I grepped
ci/,dev/,python/setup.py,python/pyproject.tomlandpython/MANIFEST.infor references and foundnone. The only remaining mention in the repository is a historical
CHANGELOG.mdentry forARROW-1033, left as is.
Are there any user-facing changes?
No.
AI usage disclosure
I used Claude Code to grep the repository for remaining references to the two scripts and to
help draft this description. The change itself is a two file deletion, and I reviewed both the
search results and the diff.