GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out#49929
GH-49901: [R] Bump minimum supported R version to 4.2 now that 4.6 is out#49929thisisnic wants to merge 10 commits intoapache:mainfrom
Conversation
| run: | | ||
| # RTools 40 uses GCC 8.x which does not support C++20 chrono timezones, | ||
| # so Arrow uses the vendored date library which requires tzdata | ||
| # Download tzdata in case the vendored date library is used for timezones |
There was a problem hiding this comment.
Does the RTools bump and associated GCC version increase means that this is no longer needed?
There was a problem hiding this comment.
@amoeba would know more than I do, but I think we still need to workaround the tz file issue, but we now do that with an R package instead of the C++ program thing here. Or am I confused about that?
There was a problem hiding this comment.
I updated the comment to be clearer now.
There was a problem hiding this comment.
I think we can remove this, but a separate PR is fine. We still need to use this script in other CI jobs where R isn't involved.
| {% set r_release = {"ver": "4.2", "rt" : "42"} %} | ||
| {% set r_oldrel = {"ver": "4.1", "rt" : "40"} %} |
There was a problem hiding this comment.
These variables are never used anywhere
|
@github-actions crossbow submit -g r |
|
Revision: 682fe0a Submitted crossbow builds: ursacomputing/crossbow @ actions-8480702cfb |
| # Ensure CA certificates are available for pacman (Rtools42+ may not bundle them) | ||
| if [ ! -f /usr/ssl/certs/ca-bundle.crt ]; then | ||
| mkdir -p /usr/ssl/certs | ||
| for src in /c/rtools45/usr/ssl/certs/ca-bundle.crt \ | ||
| "/c/Program Files/Git/mingw64/etc/ssl/certs/ca-bundle.crt"; do | ||
| if [ -f "$src" ]; then | ||
| cp "$src" /usr/ssl/certs/ca-bundle.crt | ||
| break | ||
| fi | ||
| done | ||
| fi |
There was a problem hiding this comment.
Claude addition as job fails if we don't do this - unsure if best approach but looks like a CI-specific failure and will see if it makes the CI pass.
There was a problem hiding this comment.
Rtools42 definitely bundles these so something else must be going on. I just checked by installing Rtools42 and /usr/ssl/certs is all set up and pacman works fine.
There was a problem hiding this comment.
Thanks for checking, will push some changes which print paths etc to see more of what's happening.
|
Are those two crossbow failures on main too? Do we have issues for them? |
Yes, they've been failing on the nightlies for ~a week. See: |
|
The |
|
@github-actions crossbow submit test-r-arrow-backwards-compatibility |
|
Revision: ce6d929 Submitted crossbow builds: ursacomputing/crossbow @ actions-756eb23241
|
|
The ticket for |
|
Is the R / AMD64 Windows C++ RTools 42 ucrt64 failure on main too? |
Nope, good spot, this is the one I'm trying to fix with the CA certificate shenanigans that RTools42 dislikes. Will iterate to see if I can sort it. |
Rationale for this change
We don't need to support R 4.1 as a new version is out
What changes are included in this PR?
Bump minimum supported version to 4.2
Are these changes tested?
In CI, sure
Are there any user-facing changes?
Nope