-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48904: [C++][FlightRPC][CI][Packaging] Upload ODBC installer into GitHub release as RC #48934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
| cd ../.. | ||
| Move-Item -Path "build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi" -Destination "." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved path to make it easier for uploading GitHub release
.github/workflows/cpp_extra.yml
Outdated
| run: | | ||
| gh release upload ${GITHUB_REF_NAME} \ | ||
| --clobber \ | ||
| "Apache Arrow Flight SQL ODBC-*-win64.msi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No release notes are added in this PR. Please let me know if I should put the release notes in the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to add release notes here.
.github/workflows/cpp_extra.yml
Outdated
| run: | | ||
| gh release upload ${GITHUB_REF_NAME} \ | ||
| --clobber \ | ||
| "Apache Arrow Flight SQL ODBC-*-win64.msi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to add release notes here.
.github/workflows/cpp_extra.yml
Outdated
| run: | | ||
| gh release upload ${GITHUB_REF_NAME} \ | ||
| --clobber \ | ||
| "Apache Arrow Flight SQL ODBC-*-win64.msi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Apache Arrow Flight SQL ODBC-*-win64.msi" will not be expanded by bash...:
| "Apache Arrow Flight SQL ODBC-*-win64.msi" | |
| Apache\ Arrow\ Flight\ SQL\ ODBC-*-win64.msi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested "Apache Arrow Flight SQL ODBC-*-win64.msi" on my forked repo and it worked, I have tested your suggestion and I think both approaches work here. I updated the code
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alinaliBQ for working on this!
From my understanding we are going to integrate this to the major quarterly Arrow releases. Should we modify the tag to be triggered only on RCs, similar to how we do on Linux packaging jobs:
arrow/.github/workflows/package_linux.yml
Lines 38 to 39 in 9cde706
| tags: | |
| - "apache-arrow-*-rc*" |
We should also add it to the binary download:
arrow/dev/release/04-binary-download.sh
Lines 50 to 58 in 9cde706
| gh release download "${tag}" \ | |
| --dir "packages/${CROSSBOW_JOB_ID}" \ | |
| --pattern "almalinux-*.tar.gz" \ | |
| --pattern "amazon-linux-*.tar.gz" \ | |
| --pattern "centos-*.tar.gz" \ | |
| --pattern "debian-*.tar.gz" \ | |
| --pattern "ubuntu-*.tar.gz" \ | |
| --repo "${REPOSITORY:-apache/arrow}" \ | |
| --skip-existing |
and the signing and upload to sign the released artifacts:
arrow/dev/release/05-binary-upload.sh
Lines 64 to 72 in 9cde706
| : "${UPLOAD_DEFAULT:=1}" | |
| : "${UPLOAD_ALMALINUX:=${UPLOAD_DEFAULT}}" | |
| : "${UPLOAD_AMAZON_LINUX:=${UPLOAD_DEFAULT}}" | |
| : "${UPLOAD_CENTOS:=${UPLOAD_DEFAULT}}" | |
| : "${UPLOAD_DEBIAN:=${UPLOAD_DEFAULT}}" | |
| : "${UPLOAD_DOCS:=${UPLOAD_DEFAULT}}" | |
| : "${UPLOAD_PYTHON:=${UPLOAD_DEFAULT}}" | |
| : "${UPLOAD_R:=${UPLOAD_DEFAULT}}" | |
| : "${UPLOAD_UBUNTU:=${UPLOAD_DEFAULT}}" |
I am unsure if there is anything we have to do on verification apart from validating signatures. From my understanding if we upload to GH Release and add signatures the verification script will already validate the signature (nothing has to be done there) but better to double check.
Rationale for this change
#48904
Upload ODBC as a GitHub draft release upon release candidate tag
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Yes, this PR adds GitHub release for Apache Arrow Flight SQL ODBC MSI installer.