Skip to content

Conversation

@alinaliBQ
Copy link
Collaborator

@alinaliBQ alinaliBQ commented Jan 21, 2026

Rationale for this change

#48904

Upload ODBC as a GitHub draft release upon release candidate tag

What changes are included in this PR?

  • Create a draft GitHub release for ODBC, and upload the ODBC MSI to the draft release.

Are these changes tested?

  • Tested in forked repository, a draft GitHub release is created

Are there any user-facing changes?

Yes, this PR adds GitHub release for Apache Arrow Flight SQL ODBC MSI installer.

@github-actions github-actions bot added the awaiting review Awaiting review label Jan 21, 2026
@github-actions
Copy link

⚠️ GitHub issue #48904 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the CI: Extra: C++ Run extra C++ CI label Jan 21, 2026
Comment on lines +456 to +457
cd ../..
Move-Item -Path "build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi" -Destination "."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved path to make it easier for uploading GitHub release

@alinaliBQ alinaliBQ changed the title GH-48904: [C++][FlightRPC][CI][Packaging] work-in-progress: Upload ODBC installer into GitHub release as RC GH-48904: [C++][FlightRPC][CI][Packaging] Upload ODBC installer into GitHub release as RC Jan 21, 2026
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 21, 2026
Comment on lines 479 to 482
run: |
gh release upload ${GITHUB_REF_NAME} \
--clobber \
"Apache Arrow Flight SQL ODBC-*-win64.msi"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No release notes are added in this PR. Please let me know if I should put the release notes in the PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to add release notes here.

@alinaliBQ alinaliBQ marked this pull request as ready for review January 21, 2026 23:29
Comment on lines 479 to 482
run: |
gh release upload ${GITHUB_REF_NAME} \
--clobber \
"Apache Arrow Flight SQL ODBC-*-win64.msi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to add release notes here.

run: |
gh release upload ${GITHUB_REF_NAME} \
--clobber \
"Apache Arrow Flight SQL ODBC-*-win64.msi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Apache Arrow Flight SQL ODBC-*-win64.msi" will not be expanded by bash...:

Suggested change
"Apache Arrow Flight SQL ODBC-*-win64.msi"
Apache\ Arrow\ Flight\ SQL\ ODBC-*-win64.msi

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested "Apache Arrow Flight SQL ODBC-*-win64.msi" on my forked repo and it worked, I have tested your suggestion and I think both approaches work here. I updated the code

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jan 22, 2026
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alinaliBQ for working on this!
From my understanding we are going to integrate this to the major quarterly Arrow releases. Should we modify the tag to be triggered only on RCs, similar to how we do on Linux packaging jobs:

tags:
- "apache-arrow-*-rc*"

We should also add it to the binary download:
gh release download "${tag}" \
--dir "packages/${CROSSBOW_JOB_ID}" \
--pattern "almalinux-*.tar.gz" \
--pattern "amazon-linux-*.tar.gz" \
--pattern "centos-*.tar.gz" \
--pattern "debian-*.tar.gz" \
--pattern "ubuntu-*.tar.gz" \
--repo "${REPOSITORY:-apache/arrow}" \
--skip-existing

and the signing and upload to sign the released artifacts:
: "${UPLOAD_DEFAULT:=1}"
: "${UPLOAD_ALMALINUX:=${UPLOAD_DEFAULT}}"
: "${UPLOAD_AMAZON_LINUX:=${UPLOAD_DEFAULT}}"
: "${UPLOAD_CENTOS:=${UPLOAD_DEFAULT}}"
: "${UPLOAD_DEBIAN:=${UPLOAD_DEFAULT}}"
: "${UPLOAD_DOCS:=${UPLOAD_DEFAULT}}"
: "${UPLOAD_PYTHON:=${UPLOAD_DEFAULT}}"
: "${UPLOAD_R:=${UPLOAD_DEFAULT}}"
: "${UPLOAD_UBUNTU:=${UPLOAD_DEFAULT}}"

I am unsure if there is anything we have to do on verification apart from validating signatures. From my understanding if we upload to GH Release and add signatures the verification script will already validate the signature (nothing has to be done there) but better to double check.

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting change review Awaiting change review CI: Extra: C++ Run extra C++ CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants