Skip to content

Conversation

@alinaliBQ
Copy link
Collaborator

@alinaliBQ alinaliBQ commented Jan 21, 2026

Rationale for this change

#48932

What changes are included in this PR?

  • Fix rsync build error ODBC Nightly Package

Are these changes tested?

  • tested in CI

Are there any user-facing changes?

  • After fix, users should be able to get Nightly ODBC package release

@github-actions
Copy link

⚠️ GitHub issue #48932 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added CI: Extra: C++ Run extra C++ CI awaiting review Awaiting review labels Jan 21, 2026
To resolve error `rsync command not found`
@alinaliBQ alinaliBQ force-pushed the gh-48932-fix-nightly-odbc-package branch from d14fa36 to a4f144d Compare January 21, 2026 22:44
@alinaliBQ alinaliBQ changed the title GH-48932: [C++][Packaging][FlightRPC] Work-in-progress Fix rsync build error ODBC Nightly Package GH-48932: [C++][Packaging][FlightRPC] Fix rsync build error ODBC Nightly Package Jan 21, 2026
@alinaliBQ alinaliBQ marked this pull request as ready for review January 21, 2026 23:28
@kou
Copy link
Member

kou commented Jan 22, 2026

It may be better that we use Ubuntu instead of Windows something like the following because .github/actions/sync-nightlies/ assumes Linux:

diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml
index 68f47926ad..23ffdd486f 100644
--- a/.github/workflows/cpp_extra.yml
+++ b/.github/workflows/cpp_extra.yml
@@ -457,15 +457,23 @@ jobs:
           name: flight-sql-odbc-msi-installer
           path: build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi
           if-no-files-found: error
-      # Upload ODBC installer as nightly release in scheduled runs
+
+  odbc-nightly:
+    needs: odbc
+    name: ODBC nightly
+    runs-on: ubuntu-latest
+    if: github.event_name == 'schedule' && github.repository = 'apache/arrow'
+    steps:
+      - name: Download the artifacts
+        uses: actions/download-artifact@v7
+        with:
+          name: flight-sql-odbc-msi-installer
       - name: Prepare ODBC installer for sync
-        if: github.event_name == 'schedule'
         run: |
           mkdir odbc-installer
-          Move-Item "build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi" odbc-installer/
-          tree odbc-installer /f
+          mv *.msi odbc-installer/
+          tree odbc-installer
       - name: Sync to Remote
-        if: github.event_name == 'schedule'
         uses: ./.github/actions/sync-nightlies
         with:
           upload: true

@alinaliBQ
Copy link
Collaborator Author

@kou Good suggestion, I have applied your code suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review Awaiting review CI: Extra: C++ Run extra C++ CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants