-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48932: [C++][Packaging][FlightRPC] Fix rsync build error ODBC Nightly Package
#48933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alinaliBQ
wants to merge
8
commits into
apache:main
Choose a base branch
from
Bit-Quill:gh-48932-fix-nightly-odbc-package
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GH-48932: [C++][Packaging][FlightRPC] Fix rsync build error ODBC Nightly Package
#48933
alinaliBQ
wants to merge
8
commits into
apache:main
from
Bit-Quill:gh-48932-fix-nightly-odbc-package
+22
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
To resolve error `rsync command not found`
d14fa36 to
a4f144d
Compare
rsync build error ODBC Nightly Packagersync build error ODBC Nightly Package
Member
|
It may be better that we use Ubuntu instead of Windows something like the following because diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml
index 68f47926ad..23ffdd486f 100644
--- a/.github/workflows/cpp_extra.yml
+++ b/.github/workflows/cpp_extra.yml
@@ -457,15 +457,23 @@ jobs:
name: flight-sql-odbc-msi-installer
path: build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi
if-no-files-found: error
- # Upload ODBC installer as nightly release in scheduled runs
+
+ odbc-nightly:
+ needs: odbc
+ name: ODBC nightly
+ runs-on: ubuntu-latest
+ if: github.event_name == 'schedule' && github.repository = 'apache/arrow'
+ steps:
+ - name: Download the artifacts
+ uses: actions/download-artifact@v7
+ with:
+ name: flight-sql-odbc-msi-installer
- name: Prepare ODBC installer for sync
- if: github.event_name == 'schedule'
run: |
mkdir odbc-installer
- Move-Item "build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi" odbc-installer/
- tree odbc-installer /f
+ mv *.msi odbc-installer/
+ tree odbc-installer
- name: Sync to Remote
- if: github.event_name == 'schedule'
uses: ./.github/actions/sync-nightlies
with:
upload: true |
* Assuming ubuntu comes with built-in rsync
This reverts commit 4fca198.
Collaborator
Author
|
@kou Good suggestion, I have applied your code suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#48932
What changes are included in this PR?
rsyncbuild error ODBC Nightly PackageAre these changes tested?
Are there any user-facing changes?
rsynccommand not found for ODBC Nightly Release step #48932