GH-48866: [C++][Gandiva] Truncate subseconds beyond milliseconds in castTIMESTAMP_utf8 and castTIME_utf8
#48867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
@kou Could you plz take a look? |
kou
reviewed
Jan 22, 2026
cpp/src/gandiva/precompiled/time.cc
Outdated
Comment on lines
750
to
754
| // Truncate to 3 digits (milliseconds precision) if more digits are provided | ||
| while (sub_seconds_len > 3) { | ||
| ts_fields[TimeFields::kSubSeconds] /= 10; | ||
| sub_seconds_len--; | ||
| } |
Member
There was a problem hiding this comment.
Can we factor out this common code?
Author
There was a problem hiding this comment.
Thanks for review, moved common code in the separate inline function
Member
|
@xxlaykxx Could you also review this? We don't have enough maintainers for Gandiva. |
Member
|
@akravchukdremio Could you rebase on main to fix CI failures? |
akravchukdremio
force-pushed
the
GH-48866
branch
from
5aac113 to
3d7ef89
Compare
Author
Sure, rebased PR |
github-actions
bot
added
awaiting committer review
…s in `castTIMESTAMP_utf8` and `castTIME_utf8`
akravchukdremio
force-pushed
the
GH-48866
branch
from
3d7ef89 to
b818113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #48866. The Gandiva precompiled time functions
castTIMESTAMP_utf8andcastTIME_utf8currently reject timestamp and time string literals with more than 3 subsecond digits (beyond millisecond precision), throwing an "Invalid millis" error. This behavior is inconsistent with other implementations.What changes are included in this PR?
castTIMESTAMP_utf8andcastTIME_utf8functions to truncate subseconds beyond 3 digits instead of throwing an errorAre these changes tested?
Yes
Are there any user-facing changes?
No
castTIMESTAMP_utf8andcastTIME_utf8should truncate subseconds beyond milliseconds, not reject them #48866