Skip to content

GH-14790: [Dev] Avoid extra comment with Closes issue id on PRs #35811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raulcd merged 2 commits into from
May 30, 2023
Merged

GH-14790: [Dev] Avoid extra comment with Closes issue id on PRs #35811

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed58d79
GH-14790: [Dev] Avoid extra comment with Closes XXXX on PRs
raulcd May 28, 2023
41e4b24
Update .github/workflows/dev_pr/link.js
raulcd May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions .github/workflows/dev_pr/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,22 +83,16 @@ async function commentGitHubURL(github, context, pullRequestNumber, issueID) {
// Make the call to ensure issue exists before adding comment
const issueInfo = await helpers.getGitHubInfo(github, context, issueID, pullRequestNumber);
const message = "* Closes: #" + issueInfo.number
if (await haveComment(github, context, pullRequestNumber, message)) {
return;
}
if (issueInfo){
if (context.payload.pull_request.body.includes(message)){
Comment thread
raulcd marked this conversation as resolved.
Outdated
return;
}
await github.pulls.update({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: pullRequestNumber,
body: (context.payload.pull_request.body || "") + "\n" + message
});
await github.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pullRequestNumber,
body: message
});
}
}

Expand Down