[WIP] fix(parquet): preserve explicit mask with sparse pages#10288
Draft
hhhizzz wants to merge 2 commits into
Draft
[WIP] fix(parquet): preserve explicit mask with sparse pages#10288hhhizzz wants to merge 2 commits into
hhhizzz wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explicit
RowSelectionPolicy::Masknow works when page pruning has loaded only sparse page ranges. Instead of decoding rows whose pages were intentionally skipped, the read plan carries loaded row ranges into a sparse mask cursor and the record batch reader decodes only backed selected segments.Autokeeps its existing safety behavior by falling back to selectors for unsafe sparse page-loaded masks, so this stays scoped to the mask-preserving correctness path and does not import the broader reference branch's post-filter, cost-model, metrics, benchmark, CI, changelog, or dependency work.Validation
cargo fmt --all --checkgit diff --checkcargo test -p parquet --features arrow --lib selectioncargo test -p parquet --features arrow,async --test arrow_reader row_filtercargo test -p parquet --features arrow,async --test arrow_reader predicate_cachePost-Deploy Monitoring & Validation
No additional operational monitoring required. This is a parquet reader correctness fix covered by unit and row-filter integration regressions; downstream validation should come from normal CI and parquet reader test coverage.