bench(parquet): add Sbbf check/insert benchmarks#10041
Merged
Merged
Conversation
Adds `bench_check` (miss/hit x 128KiB/2MiB/32MiB cache regimes) and
`bench_insert`, both exercising the public `Sbbf::{check,insert}` API.
The miss set is constructed disjoint from the inserted set (high bit of
byte 0 flipped) so the miss path is genuinely a miss, not a
birthday-paradox near-miss.
Precursor to the Sbbf autovectorization change (apache#10011) so before/after
numbers can be reproduced against benchmarks already on main.
dmatth1
changed the title
etseidl
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
bench_checkandbench_insertbenchmarks forSbbf::{check,insert}. Originally benchmarks were part of #10011 but were split out to follow Contributing guidelinesAre these changes tested?
Benchmarks compiled and ran using
cargo bench -p parquet --bench bloom_filter.Are there any user-facing changes?
No.