-
Notifications
You must be signed in to change notification settings - Fork 18
feat: Add missing type to Struct
#340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Divyanshu-s13
wants to merge
12
commits into
apache:main
Choose a base branch
from
Divyanshu-s13:strong-typing-for-builders
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8354f7c
Fix: Updated LICENSE reference to LICENSE.txt
5552226
Fix:[JS] Strong typing for builders
a11a307
remove unused file
5621b52
Merge branch 'main' into strong-typing-for-builders
Divyanshu-s13 e86951c
chore: remove unnecessary is-relative dependency
0525b22
original yarn.lock
b784274
fix: resolve TypeScript compilation errors in strong-typing-for-builders
5fd1900
fix cli failure and fix issue #90
2ad4fac
added a test case
531a67b
restore: re-add eslint.config.js
957d656
chore: add Apache 2.0 license header to struct-builder test
c7d5c6b
fix yarn.lock
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right to call that out. I apologize for the confusion in my previous response.
This dependency isn't needed. I added it by mistake while working locally. I've removed it now to keep the package.json clean. Thanks for pointing it out!