GH-993: Fix missing pipe in milestone assignment script #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The head -n1 command was not piped to grep output, causing all matching milestones to be captured instead of just the first one. Example failure: Assigning milestone: 19.0.0 20.0.0 '19.0.0 20.0.0' not found
tmater
requested review from
jbonofre,
kou,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
tmater
changed the title
Member
|
That's not a big deal as in this case the milestone assignment is made by hand (which make sense to select the right milestone). But ok, let's use a default milestone and update by hand if needed. |
Contributor
Author
Thanks for the review, @jbonofre! I don’t think this is a major issue either. From the script, it looks like the intention is to pick the first result returned, which is why I submitted this fix. |
jbonofre
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
head -n1command was not piped to grep output, causing all matching milestones to be captured instead of just the first one.Example failure:
Closes #993