Skip to content

MINOR: Don't uninstall Flatbuffers in CI #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 2 commits into from
Apr 14, 2025
Merged

MINOR: Don't uninstall Flatbuffers in CI #711

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef28fe0
MINOR: Don't uninstall Flatbuffers in CI
lidavidm Apr 14, 2025
a53eeda
disable tests by default
lidavidm Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/rc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,11 +261,6 @@ jobs:
# bundled Protobuf.
brew uninstall protobuf

# We need Flatbuffers 24, not the latest version
# Homebrew does not offer older versions, so remove the Homebrew
# package and rely on Arrow using a bundled version instead
brew uninstall flatbuffers

brew bundle --file=Brewfile
- name: Prepare ccache
run: |
Expand All @@ -281,6 +276,7 @@ jobs:
set -e
# make brew Java available to CMake
export JAVA_HOME=$(brew --prefix openjdk@11)/libexec/openjdk.jdk/Contents/Home
export ARROW_BUILD_TESTS=OFF
Copy link
Copy Markdown
Member Author

@lidavidm lidavidm Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled this

(1) we're not running the tests in CI anyways, so we might as well save some time
(2) they fail to build currently due to whatever Boost/Homebrew just did

Copy link
Copy Markdown
Member

@kou kou Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about disabling tests by default?

diff --git a/ci/scripts/jni_macos_build.sh b/ci/scripts/jni_macos_build.sh
index 65b255e2..f7543b6f 100755
--- a/ci/scripts/jni_macos_build.sh
+++ b/ci/scripts/jni_macos_build.sh
@@ -61,7 +61,7 @@ github_actions_group_begin "Building Arrow C++ libraries"
 install_dir="${build_dir}/cpp-install"
 : "${ARROW_ACERO:=ON}"
 export ARROW_ACERO
-: "${ARROW_BUILD_TESTS:=ON}"
+: "${ARROW_BUILD_TESTS:=OFF}"
 export ARROW_BUILD_TESTS
 : "${ARROW_DATASET:=ON}"
 export ARROW_DATASET

ci/scripts/jni_macos_build.sh . arrow build jni
- name: Compress into single artifact to keep directory structure
run: tar -cvzf jni-macos-${{ matrix.platform.arch }}.tar.gz jni/
Expand Down
Loading