fix(parquet): row-align V1 pages with offset indexes - #1075
Open
fallintoplace wants to merge 2 commits into
Open
fix(parquet): row-align V1 pages with offset indexes#1075fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #887
Problem
Parquet pages referenced by an OffsetIndex must begin at row boundaries. The writer already enforced this for repeated DataPageV2 columns, but repeated DataPageV1 columns still used fixed-size batching when page indexes were enabled. A logical row could consequently span two indexed V1 pages.
Change
Reuse the existing repetition-level-aware batching for repeated V1 columns when page indexing is enabled. The same condition is applied to the generated variable-length writer paths. V1 writes without page indexes retain the existing fixed-size batching behavior.
Coverage
The regression test uses indexed V1 pages, repeated three-value rows, and a batch size that does not divide the row width. It closes the writer to verify the final buffered page as well as intermediate pages.
Validation
go test ./parquet/file -run 'TestDataPageV1OffsetIndexRowBoundaries|TestDataPageV2RowBoundaries' -count=1