fix(parquet): reject truncated footer signatures - #1074
Open
fallintoplace wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FileMetaData.VerifySignaturesliced the supplied signature into nonce and tag fields before validating its length. A truncated signature could therefore trigger an out-of-range panic instead of being rejected.Change
Return
falsewhen the signature is shorter than the required nonce plus GCM tag length. Valid-length signature verification continues through the existing constant-time comparison path.Coverage
The regression test covers every truncated length and the exact minimum boundary, confirming that malformed input is rejected without panicking.
Validation
go test ./parquet/metadata