fix(array): format date arrays in String - #1068
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63
Problem
Date32 and Date64 arrays inherited the numeric array
Stringimplementation, so their values were rendered as raw integers instead of dates. This was inconsistent with their existingValueStrand JSON formatting.Change
Give date arrays a
Stringimplementation that formats each non-null value throughValueStr. Null markers, slice behavior, and the established array layout are preserved.Coverage
The tests cover Date32, Date64, null values, negative dates, and sliced arrays. Generated builder expectations are updated to match the user-visible date representation.
Validation
go test ./arrow/array