fix(arrow/flight/flightsql): avoid double-retaining parameter readers - #1066
Open
fallintoplace wants to merge 3 commits into
Open
fix(arrow/flight/flightsql): avoid double-retaining parameter readers#1066fallintoplace wants to merge 3 commits into
fallintoplace wants to merge 3 commits into
Conversation
serramatutu
suggested changes
Jul 30, 2026
serramatutu
left a comment
serramatutu
left a comment
Contributor
There was a problem hiding this comment.
I don't think ref counting is the way for this. Also, can you add a test to repro the specific bug you're trying to fix?
| mock.Mock | ||
| } | ||
|
|
||
| type referenceCountingReader struct { |
Contributor
There was a problem hiding this comment.
This ref counting mechanism is used only in one place and is not a widespread architectural pattern. To me this is a signal that this is a workaround for a bug instead of an actual good fix.
I think the proper solution for readers is ensuring we do lifecycle management right (i.e call Retain() in the right places) instead of adding ref counting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Remove the duplicate retain in
PreparedStatement.SetRecordReader.Why
The setter retained the supplied reader twice, while parameter replacement and statement close released it only once. This left one reference permanently owned by the statement.
The regression test binds an allocator-backed record reader, drops the caller-owned references, then replaces the binding. The statement's single release must free the record buffers; the previous double retain leaves them allocated.
Testing
go test ./arrow/flight/flightsqlgo test -race ./arrow/flight/flightsql -run TestPreparedStatementReleasesRecordReaderBindingOnce