fix(arrow/ipc): return errors for malformed file record batches - #1062
Open
fallintoplace wants to merge 1 commit into
Open
fix(arrow/ipc): return errors for malformed file record batches#1062fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
IPC stream reads convert record-loading panics from malformed messages into errors.
FileReader.RecordBatchAtused the same loader without that boundary, so malformed record metadata could panic through an API that returns an error.What changes are included in this PR?
Add an error-returning boundary around file record construction using the same recovered-error formatting as the stream reader. The explicit record-index bounds panic remains unchanged.
Are these changes tested?
Yes. A regression test supplies malformed metadata and verifies an error with no record.
go test ./arrow/ipc -run TestLoadRecordBatchReturnsMalformedMetadataErrorsAre there any user-facing changes?
Corrupt IPC file batches now return an error instead of panicking.