fix(parquet/pqarrow): release partially constructed field readers - #1061
Open
fallintoplace wants to merge 2 commits into
Open
fix(parquet/pqarrow): release partially constructed field readers#1061fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
serramatutu
suggested changes
Jul 30, 2026
| }) | ||
| } | ||
| if err = g.Wait(); err != nil { | ||
| for _, rdr := range out { |
Contributor
There was a problem hiding this comment.
Can we add a unit test to repro the bug?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GetFieldReadersconstructs readers concurrently. If one fails after another succeeds, the successful reader remains in a private slice and is never returned, so the caller cannot release it.What changes are included in this PR?
When construction fails, release every non-nil reader that completed before returning the original error.
Are these changes tested?
Yes. The regression test injects a read failure at the second column chunk after the first reader has been constructed. Without the cleanup, the checked allocator reports the first page reader's retained buffer; with the fix, allocator usage returns to zero.
go test ./parquet/pqarrow -run TestGetFieldReadersReleasesPartialReadersOnErrorAre there any user-facing changes?
No API changes. Failed multi-column reader construction now cleans up partial results.