fix(arrow/csv): release Reader record builders - #1059
Open
fallintoplace wants to merge 2 commits into
Open
Conversation
fallintoplace
changed the title
serramatutu
suggested changes
Jul 30, 2026
| } | ||
| } | ||
|
|
||
| func TestReaderReleaseFreesRecordBuilder(t *testing.T) { |
Contributor
There was a problem hiding this comment.
I reverted your changes and ran the test on top of main. It passes without reproducing any bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Every CSV reader owns a
RecordBuilder, but finalReader.Releasedid not release it. Header processing with an explicit schema also replaced the initial builder without releasing it, leaking two builders on that path.What changes are included in this PR?
Release the old builder before header-driven replacement, and release the active builder when the reader reference count reaches zero.
Are these changes tested?
Yes. The regression test uses a supported custom extension builder that reserves allocator-backed storage when constructed and counts releases. It covers explicit-schema readers with and without headers, proving that one builder is released on the direct path and both builders are released on the header-replacement path.
go test ./arrow/csv -run TestReaderReleaseFreesRecordBuildersAre there any user-facing changes?
No API changes. Releasing a CSV reader now frees every builder it owns.