fix(parquet/metadata): use default writer properties when props is nil - #1058
Open
fallintoplace wants to merge 2 commits into
Open
fix(parquet/metadata): use default writer properties when props is nil#1058fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
NewFileMetadataBuilderdocuments that nil writer properties select the defaults, but dereferencedpropswhile checking encryption settings and panicked.What changes are included in this PR?
Initialize standard writer properties when
propsis nil, before reading encryption configuration.Are these changes tested?
Yes. A regression test exercises the documented nil call with a valid schema.
go test ./parquet/metadata -run TestNewFileMetadataBuilderUsesDefaultPropertiesAre there any user-facing changes?
Passing nil writer properties now behaves as documented.