fix(parquet/metadata): return schema initialization errors - #1056
Open
fallintoplace wants to merge 2 commits into
Open
fix(parquet/metadata): return schema initialization errors#1056fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
NewFileMetaDatadiscarded the error frominitSchemaand immediately initialized column orders. When malformed metadata could not produce a schema, this could dereference the unset schema and panic.What changes are included in this PR?
Return the schema initialization error before touching column orders.
Are these changes tested?
Yes. A regression test serializes invalid schema metadata and verifies an error with no result.
go test ./parquet/metadata -run TestNewFileMetaDataReturnsSchemaErrorsAre there any user-facing changes?
Malformed metadata now returns its schema error instead of potentially panicking.