fix(parquet/metadata): reject negative row-group indices in Subset - #1055
Open
fallintoplace wants to merge 1 commit into
Open
fix(parquet/metadata): reject negative row-group indices in Subset#1055fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
FileMetaData.Subsetchecked only the upper bound. Negative indices passed validation and later caused a runtime bounds panic despite the method having an error return.What changes are included in this PR?
Reject indices below zero as well as indices at or above the row-group count.
Are these changes tested?
Yes. Regression cases cover an isolated negative index and mixed valid/invalid input.
go test ./parquet/metadataAre there any user-facing changes?
Negative selections now return an error instead of panicking.