fix(arrow/ipc): reject non-dictionary initial messages - #1054
Open
fallintoplace wants to merge 1 commit into
Open
fix(arrow/ipc): reject non-dictionary initial messages#1054fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When an IPC schema declares dictionaries, the reader expects dictionary batches before records. It detected an unexpected message but continued into
readDictionary, which could replace the useful protocol error and consume the wrong message.What changes are included in this PR?
Stop immediately, mark the reader done, and preserve the expected-dictionary error.
Are these changes tested?
Yes. A regression test provides a dictionary schema followed directly by a record batch.
go test ./arrow/ipc -run TestReaderRejectsRecordBatchBeforeInitialDictionaryAre there any user-facing changes?
Malformed streams now fail deterministically with the specific dictionary-ordering error.