fix(parquet/file): close file on OpenParquetFile errors - #1053
Open
fallintoplace wants to merge 2 commits into
Open
fix(parquet/file): close file on OpenParquetFile errors#1053fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
OpenParquetFileopens a file or mmap before constructing the reader. If initialization fails while parsing metadata, the function returned without closing that owned source.What changes are included in this PR?
Require the internally opened source to implement
ReaderAt,Seeker, andCloser, then close it whenNewParquetReaderfails. Preserve a simultaneous close failure witherrors.Join.Are these changes tested?
Yes. A close-tracking regression test verifies that malformed input closes the owned source, and the mmap signature cross-compiles on Windows.
go test ./parquet/file -run TestOpenParquetFileClosesSourceOnErrorAre there any user-facing changes?
Invalid files still return an error, but their file descriptor or mmap is released promptly.