fix(go/adbc/drivermgr): adjust ingest helper to set target before BindStream#4308
Open
arnoldwakim wants to merge 1 commit into
Open
fix(go/adbc/drivermgr): adjust ingest helper to set target before BindStream#4308arnoldwakim wants to merge 1 commit into
arnoldwakim wants to merge 1 commit into
Conversation
lidavidm
approved these changes
May 11, 2026
Member
lidavidm
left a comment
There was a problem hiding this comment.
I suppose this is reasonable but I feel like we should fix the FlightSQL driver as well, @zeroshade
zeroshade
requested changes
May 12, 2026
Member
zeroshade
left a comment
There was a problem hiding this comment.
I agree, we should fix the FlightSQL driver. But more importantly, can you add a test here?
Author
|
I will, add a test, did you have something particular in mind or just asserting that the stream was bound? Also, are you expecting me to fix the FlightSQL driver or is it something one of you wants to tackle? Thanks for the swift review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorder
IngestStreamandIngestStreamContextto setOptionKeyIngestTargetTableandOptionKeyIngestModebefore callingBindStream, matching drivers that require ingest targets up front (e.g., FlightSQL).Keep all other ingest option handling and execution flow unchanged.
Evidence (FlightSQL requirement):
go/adbc/driver/flightsql/flightsql_statement.go:630-656:The current non-patched code, raises the error: