feat(rust/driver_manager): reconcile with C++ driver manager#4121
feat(rust/driver_manager): reconcile with C++ driver manager#4121lidavidm wants to merge 3 commits intoapache:mainfrom
Conversation
lidavidm
force-pushed
the
gh-4089
branch
3 times, most recently
from
41380e7 to
0a70967
Compare
| works see :doc:`how_manager`. | ||
|
|
||
| There are two ways to pass connection options to driver managers: | ||
| There are two ways to pass driver options through the driver manager: |
There was a problem hiding this comment.
"driver and database options" ?
There was a problem hiding this comment.
I changed it to "database options" since that's technically correct.
|
|
||
| # The version is required. | ||
| profile_version = 1 | ||
| # It is optional to provide the driver. |
There was a problem hiding this comment.
should we mention that if the driver is not provided here it must be set as an option manually?
| This can be done via the ``additional_profile_search_path_list`` option. It | ||
| must be set before ``AdbcDatabaseInit()``. The value of this option is an | ||
| OS-specific delimited list (``:`` on Unix, ``;`` on Windows), or ``NULL`` to | ||
| clear. |
There was a problem hiding this comment.
it doesn't look like this is being added to the rust driver manager code to check for this option, shouldn't we add that? Or am I missing it?
There was a problem hiding this comment.
The Rust code doesn't have special intercepted options in the first place (like "profile" or even "uri"), so I don't think it makes sense to add this to Rust, either.
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
Looks good to me other than the couple of questions above
2 participants
Closes #4089.