Skip to content

[AMORO-4263] Persist cleanup operation metrics for Dashboard display#4265

Merged
zhoujinsong merged 3 commits into
apache:masterfrom
zhangwl9:AMORO-add_cleanup_metric-dev
Jul 8, 2026
Merged

[AMORO-4263] Persist cleanup operation metrics for Dashboard display#4265
zhoujinsong merged 3 commits into
apache:masterfrom
zhangwl9:AMORO-add_cleanup_metric-dev

Conversation

@zhangwl9

@zhangwl9 zhangwl9 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Why are the changes needed?

Close #4263.

Brief change log

  • Change TableMaintainer cleanup methods from void to Map<String,String>,
    so each operation returns file-count and size metrics.
  • Fix the summary
    persistence bug in DefaultTableProcessStore.tryTransitState() where
    the summary parameter was accepted but never persisted via updateSummary(),
    and visitable() did not copy summary across serialization.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

iShot_2026-07-06_14 54 09
  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@zhangwl9 zhangwl9 force-pushed the AMORO-add_cleanup_metric-dev branch from a67e03d to 6af9ca2 Compare July 6, 2026 07:26

@zhoujinsong zhoujinsong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit 498ea27 into apache:master Jul 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Collect per-process metrics for cleanup operations

3 participants