[AMORO-3853] Support Java 17 build for Amoro#4244
Open
xxubai wants to merge 8 commits into
Open
Conversation
Add JDK 17 compatibility
…istency in time calculations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3853.
Amoro currently cannot reliably build and validate under JDK 17 beyond the Trino-specific path. Some build configuration still assumes older JDK behavior, and the mixed Flink module uses reflective access or non-public Flink/Iceberg internals that are fragile under the Java module system.
This PR adds experimental JDK 17 build support while keeping JDK 11 as the baseline, and updates CI to validate both JDK versions.
Brief change log
java17Maven profile with the required compiler, surefire, and javadoc module opens/exports.cglib,slf4j, surefire configuration, Hudi compiler inheritance, Paimon surefire setup, and Trino toolchain matching.KerberosAwareInputFormat;StreamingReaderOperatordependency withUnkeyedStreamingReaderOperator;FlinkClassReflectionUtil;FlinkInputFormatdirectly from public table metadata;LocalDateTime, and adapting writer assertions toWriteResult.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Existing mixed Flink tests were adjusted to cover the updated JDK 17-compatible read/write paths.
Add screenshots for manual tests if appropriate
Not applicable.
Run test locally before making a pull request
./mvnw validatepassed locally with Temurin JDK 17.0.17.Documentation
Does this pull request introduce a new feature? (yes / no)
yes
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
README